DislikedHi Steve
I've setup a M15 and M30 demo, both with slope confirmation of 1.
PaulIgnored
Trying scalping with a 1000 bucks - Scalping is expensive! 39 replies
1M & 5M Scalping System (Scalping Paradise) 21 replies
Random Auto Scalping to Profits 36 replies
PwR EVA 16 replies
MoForce's PwR System 25 replies
DislikedHi Steve
I've setup a M15 and M30 demo, both with slope confirmation of 1.
PaulIgnored
DislikedHi Steve
A few trades should have been taken on Hanover M15, but I get the following in the logs: -
EURUSD opening at 0.00000 sl: 0.00000 tp: 0.00000 failed [Trade is disabled]
I have ECN = true and I'm sure I've seen this before, but can't spot anything in the code, any ideas?
Cheers
Paul
EDIT: Standby, I maybe onto something!
EDIT2: I did see it before and now remember and fixed (finger trouble not EA), trades taken and closed (in profit) for both TF's.Ignored
DislikedHi Steve
A few trades should have been taken on Hanover M15, but I get the following in the logs: -
EURUSD opening at 0.00000 sl: 0.00000 tp: 0.00000 failed [Trade is disabled]
I have ECN = true and I'm sure I've seen this before, but can't spot anything in the code, any ideas?
Cheers
Paul
EDIT: Standby, I maybe onto something!
EDIT2: I did see it before and now remember and fixed (finger trouble not EA), trades taken and closed (in profit) for both TF's.Ignored
DislikedFantastic. Thanks. There is only one of me, with my somewhat pathetically powered trading lappy, but umpteen permutations of settings of lots of bots.
What I need is lots and lots of testers. Most will go unsung.
Eventually, someone will come up with the Killer Combination.Here is hoping it is you.
Ignored
DislikedSteve,
Since starting this forward test, Aurora has taken 22 trades with 17 of these being winners. However, all the TPs were set at 2-3 pips; the SLs were correct. As a result, she is in drawdown.
It's OOTB except for Hanover:
TimeFrames=M30
SlopeConfirmationCandles=1
NumPoints=25.
Is there a 4-digit/5-digit issue in the TP code?Ignored
DislikedHi Steve
I've been looking at M15 and M30, with H using slope 0 and 1.
M30 looked to give the larger profits and win/loss was around 75/25 %. However, the losers led to little or no profit.
I'm going to try and adjust the SL/TP setting, we'll see what happens.
PaulIgnored
DislikedSteve,
Since starting this forward test, Aurora has taken 22 trades with 17 of these being winners. However, all the TPs were set at 2-3 pips; the SLs were correct. As a result, she is in drawdown.
It's OOTB except for Hanover:
TimeFrames=M30
SlopeConfirmationCandles=1
NumPoints=25.
Is there a 4-digit/5-digit issue in the TP code?Ignored
void LookForTradingOpportunities() { RefreshRates(); double price; int type; bool SendTrade; double SendLot = Lot; //Check filters if (!IsTradingAllowed() ) return; double spread = MarketInfo(Symbol(), MODE_SPREAD) * Point; //The market direction, candle size and higher/lower hi-lo have all been checked prior to reaching this point, so //all that is needed is to enter in the direction of the trend. //Set up 'phantom' pendings where a 'normal' pending would have been sent, to hide the details from the crims [color=Red]//Set up pending candle range PendingCandleRange = CandleRange; //Adapt to x digit criminals int multiplier; if(Digits == 2 || Digits == 4) multiplier = 1; if(Digits == 3 || Digits == 5) multiplier = 10; if(Digits == 6) multiplier = 100; if(Digits == 7) multiplier = 1000; PendingCandleRange*= multiplier; [/color] //Long if (trend == up && TradeLong) { if (PendingBuy) return;//No need to reset if (UseHanover && !HanoverFilter(OP_BUY) ) return; price = NormalizeDouble(High[1] + spread,Digits); PendingBuy = true; PendingSell = false;//Cancels existing pending sell PendingPrice = price; PendingTime = Time[0]; [color=Red] //PendingCandleRange = CandleRange;[/color] PendingStop = Low[1]; }//if (trend == up && TradeLong) //Short if (trend == down && TradeShort) { if (PendingSell) return;//No need to reset if (UseHanover && !HanoverFilter(OP_SELL) ) return; price = NormalizeDouble(Low[1] - spread,Digits); PendingBuy = false;//Cancels existing pending buy PendingSell = true; PendingPrice = price; [color=Red]//PendingCandleRange = CandleRange;[/color] PendingTime = Time[0]; PendingStop = High[1]; }//if (direction == down && TradeShort) //Draw a pending price line if (PendingBuy || PendingSell) { //Calculate stops if (PendingBuy) { //Flexible take profit calculator PendingTake = CalculateTakeProfit(OP_BUY, PendingPrice); PendingTake = NormalizeDouble(PendingTake - (HiddenPips * Point), Digits); //Round number filter if (UseRoundNumberFilter) { if (!RoundNumberFilter(OP_BUY, PendingPrice, PendingTake) ) { PendingBuy = false; PendingPrice = 0; return; }//if (!RoundNumberFilter(OP_BUY, PendingPrice, take) ) }//if (UseRoundNumberFilter) //Flexible stop loss calculator PendingStop = CalculateStopLoss(OP_BUY, PendingPrice); PendingStop = NormalizeDouble(PendingStop + (HiddenPips * Point), Digits); //Got this far, so draw the lines and check for immediate fill //Draw an up arrow string name = "arrow" + TimeCurrent(); ObjectCreate(name, OBJ_ARROW, 0, TimeCurrent(), price); ObjectSet(name, OBJPROP_COLOR, Green); ObjectSet(name, OBJPROP_ARROWCODE, 241); DrawPendingPriceLines(); //Look for immediate 'fill' HasBuyFilled(); }//if (PendingBuy) if (PendingSell) { //Flexible take profit calculator PendingTake = CalculateTakeProfit(OP_SELL, PendingPrice); PendingTake = NormalizeDouble(PendingTake + (HiddenPips * Point), Digits); //Round number filter if (UseRoundNumberFilter) { if (!RoundNumberFilter(OP_SELL, PendingPrice, PendingTake) ) { PendingSell = false; PendingPrice = 0; return; }//if (!RoundNumberFilter(OP_SELL, PendingPrice, take) ) }//if (UseRoundNumberFilter) //Flexible stop loss calculator PendingStop = CalculateStopLoss(OP_SELL, PendingPrice); PendingStop = NormalizeDouble(PendingStop - (HiddenPips * Point), Digits); //Draw a down arrow name = "arrow" + TimeCurrent(); ObjectCreate(name, OBJ_ARROW, 0, TimeCurrent(), price); ObjectSet(name, OBJPROP_COLOR, Red); ObjectSet(name, OBJPROP_ARROWCODE, 242); DrawPendingPriceLines(); //Look for immediate 'fill' HasSellFilled(); }//if (PendingSell) }//if (PendingBuy !! PendingSell) }//void LookForTradingOpportunities()
DislikedGeorge found the bloop - at least we think he did and he has not been wrong yet.
Fix in post 1.
Cheers George. You are a star.
For those of you who like to make the mod yourself and preserve your inputs, here is the amended trading opps function.
[code]
void LookForTradingOpportunities()
{
RefreshRates();
double price;
int type;
bool SendTrade;
double SendLot = Lot;
//Check filters
if (!IsTradingAllowed() ) return;
double spread = MarketInfo(Symbol(), MODE_SPREAD) * Point;
//The market direction, candle...Ignored
DislikedSteve,
Since starting this forward test, Aurora has taken 22 trades with 17 of these being winners. However, all the TPs were set at 2-3 pips; the SLs were correct. As a result, she is in drawdown.
It's OOTB except for Hanover:
TimeFrames=M30
SlopeConfirmationCandles=1
NumPoints=25.
Is there a 4-digit/5-digit issue in the TP code?Ignored
DislikedI had the same issue, that's the reason why I simply kept trading my system manually instead of begging for someone to solve the problem, I never was the EA kind of guy, confidence issues...
I will resume my tests with Aurora, same thing with Gi.
ThanksIgnored
DislikedI had the same issue, that's the reason why I simply kept trading my system manually instead of begging for someone to solve the problem, I never was the EA kind of guy, confidence issues...
I will resume my tests with Aurora, same thing with Gi.
ThanksIgnored
DislikedThanks Steve and George, will resume testing on Monday; I still think Aurora has potential. Having said that, have just been playing with Steve's new bot for jiva34's m1 BB scalper. Wow! Looks highly promising (but don't they all to start with?)Ignored
DislikedFFS get a grip - I wasn't begging anybody, I too kept trading, only using fixed 10p SL/TP. I was simply pointing out potential code bloops in case others were trying to use the EA and encountering the same problem, otherwise how could Steve be aware of it, let alone fix it?Ignored
DislikedSwg123 I wasn't referring to you. I was the one secretly begging for someone to make her work as my coding skills are next to nothing, but instead of insisting I quited...
For a long time I desired a automated way of trading this system because it is extremely time consuming, at least for me. I was very happy when Steve and others, you included started to contribute to make it possible. The bot had some issues wish kept it from being profitable so I just kept trading it manually, I'm glad you noticed the bloop on the code and even happier to be...Ignored
DislikedOh OK, sorry, just the way it came across (It's 10pm in Cape Town and I'm well into a nice bottle of Shiraz, so possibly am uncharacteristacally touchy!)
I'll continue testing Aurora, there are many things I like about your method and I thank you for sharing it. If I can contribute anything constructive, please be assured I will.Ignored