Zero Divide Error while trading Gold and Silver

Hi all,


Can someone help me solve the zero divide error while trading Gold and Silver (2 and 3 digits) ?


Thanks.


========================================================










//+------------------------------------------------------------------+





int init()
{
newTime = Time[0];
return(0);
}


int deinit()
{
return(0);
}


int start()
{
//if (ThereIsAlreadyATrade())
// return;


/*Only enter new trades when there is a new bar*/
AnalyzeNewBar();


if (NEW_BAR == true)
{
AnalyzeExitSituation();
AnalyzeOrderEntry();
}


return;
}






bool ThereIsAlreadyATrade()
{
bool found = false;
int totalOrders = OrdersTotal();
int i = 0;
while ((!found) && (i < totalOrders))
{
if (OrderSelect(i, SELECT_BY_POS, MODE_TRADES ) == true) // If there is the next one
{
if (OrderSymbol() == Symbol() && OrderMagicNumber() == magicNumber)
{
found = true;
}
}
i++;
}
return (found);
}






void AnalyzeNewBar() // Funct. detecting ..
{ // .. a new bar
//static datetime newTime = 0; // Time of the current bar
NEW_BAR = false; // No new bar
if(newTime != Time[0]) // Compare time
{
newTime = Time[0]; // Now time is so
NEW_BAR = true; // A new bar detected
}
}






bool AnalyzeOrderEntry()
{
RefreshRates();


double ATR = iATR(NULL,1440,14,0) ;


double stopLossDistance = ATR * StopLossAsPercentOfATR/100.00 ;
double currentSpread = Ask - Bid;
double lots;
double stopLoss;
int ticket;
double pipRange = GetPipRange();
double TP;


//Long trade
if( BullishMomentum(barsToAnalyze) )
{
//CloseBearTrades();
stopLoss = Ask - stopLossDistance;
if (TargetAsPercentOfATR == 0)
TP = 0;
else
TP = Ask + ATR * TargetAsPercentOfATR/100.00 ;


lots = GetPositionSize(stopLossDistance, Maximum_Loss_Per_Trade);


if (lots > 0)
{
Sleep(10000);
RefreshRates();
ticket = OrderSend(Symbol(),OP_BUY, lots, Ask, 2, stopLoss, TP, SYSTEM_NAME + " Entry", magicNumber);
if (ticket < 0)
{
Print("Long OrderSend failed with error #", GetLastError());
return (false);
}
else
{
Print("Long Order entered Bought at: " + Ask + " SL: " + stopLoss + " TP: " + targetPoint);
//TP = Ask + (Ask - stopLoss) * 1.0 + currentSpread;
//OrderSend(Symbol(),OP_BUY, lots, Ask, 2, stopLoss, TP, SYSTEM_NAME + " Entry");
return(true);
}
}
}


if( BearishMomentum(barsToAnalyze) )
{
//CloseBullTrades();
stopLoss = Bid + stopLossDistance;
if (TargetAsPercentOfATR == 0)
TP = 0;
else
TP = Bid - ATR * TargetAsPercentOfATR/100.00;
lots = GetPositionSize(stopLossDistance, Maximum_Loss_Per_Trade);


if (lots > 0)
{
Sleep(10000);
RefreshRates();
ticket = OrderSend(Symbol(),OP_SELL, lots, Bid, 2, stopLoss, TP, SYSTEM_NAME + " Entry", magicNumber);
if(ticket < 0)
{
Print("Short OrderSend failed with error #", GetLastError());
return (false);
}
else
{
Print("Short Order entered Sold at: " + Bid + " SL: " + stopLoss + " TP: " + targetPoint);
//TP = Bid - (stopLoss - Bid) * 1.0 - currentSpread;
//OrderSend(Symbol(),OP_SELL, lots, Bid, 2, stopLoss, TP, SYSTEM_NAME + " Entry");
return (true);
}
}
}
return (false);
}






double GetPositionSize(double stopLossDistance, double risk)
{
//Analize taking into account the MAXIMUM_LOST_PER_TRADE parameter
double accountBalance = AccountBalance();
double maximumLoss = accountBalance * risk;
double accountFreeMargin = AccountFreeMargin(); // Free margin
double oneLotPrice = MarketInfo(Symbol(),MODE_MARGINREQUIRED); // Price of 1 lot
double minimumLotSize = MarketInfo(Symbol(), MODE_MINLOT);
double lotChangeStep = MarketInfo(Symbol(), MODE_LOTSTEP);


double pipValue = GetPipValue(Symbol());


double lotsizeUnits = maximumLoss / ((1/GetPipRange()) * (stopLossDistance * pipValue));
//Print ("units to play: " + lotsizeUnits);


double lotsizeValue = (lotsizeUnits / 100000) * oneLotPrice;
//Print ("valor de la jugada: " + lotsizeValue);


//Round Lot size
double lotsToPlay = MathFloor(lotsizeValue / oneLotPrice / lotChangeStep) * lotChangeStep;// For opening


if (lotsToPlay < minimumLotSize)
lotsToPlay = minimumLotSize; // Not less than minimal


if (lotsToPlay * oneLotPrice > accountFreeMargin) // Lot larger than free margin
{
Print("Not enough margin to enter new trade. Account free margin: " + accountFreeMargin);
return (0);
}


return (lotsToPlay);
}




double GetPipRange()
{
if (StringFind(Symbol(), "JPY", 0) > 0)
return (0.01);
else
return (0.0001);
}


double GetPipValue(string symbol)
{
double tickSize = 0.0001;
if (StringFind(symbol, "JPY", 0) != -1)
tickSize = 0.01;


//Case 1 - USD is in the second part of the pair
if (StringFind(symbol, "USD", 0) == 3)
{
return (0.0001);
}


//Case 2 - USD is in the first half of the name
if (StringFind(symbol, "USD", 0) == 0)
{
return ( tickSize / MarketInfo(symbol, MODE_BID) );
}


//Case 3 - USD doesnt appear in the name of the pair
if (StringFind(symbol, "USD", 0) == -1)
{
string matchingUSDpair = GetMatchingUSDPair(symbol);


//3.1 - the matching pair contains USD in the first position
if ( StringFind(matchingUSDpair, "USD", 0) == 0
{
return ( tickSize / MarketInfo(matchingUSDpair, MODE_BID) );
}
else //3.2 - the matching pair containd USD in the second half of the name
{
return ( tickSize * MarketInfo(matchingUSDpair, MODE_BID)/ MarketInfo(symbol, MODE_BID) );
}
}
}


string GetMatchingUSDPair(string symbol)
{
string matchingPair;
string usdPairs[13] = { "EURUSD", "GBPUSD", "USDJPY", "USDCHF", "USDCAD", "AUDUSD", "NZDUSD", "USDSGD", "USDNOK", "USDDKK", "USDSEK", "USDHKD", "USDMXN" };


//Get last 3 characters of symbol entered as parameter
string baseCurrency = StringSubstr(symbol, 3, 3);


bool found = false;
int i = 0;


while ((found == false) && (i < 13) )
{
if (usdPairs == baseCurrency + "USD" || usdPairs == "USD" + baseCurrency )
{
matchingPair = usdPairs;
found = true;
}
i++;
}

return (matchingPair);
}


void AnalyzeExitSituation()
{
//Close trades that are two bars old
int totalOrders = OrdersTotal();

int i = 0;
while (i < totalOrders)
{
if (OrderSelect(i, SELECT_BY_POS, MODE_TRADES ) == true) // If there is the next one
{
if (OrderSymbol() == Symbol() && OrderMagicNumber() == magicNumber)
{
if (Time[barsToExit] >= OrderOpenTime() )
{
if (OrderType() == OP_BUY)
OrderClose(OrderTicket(), OrderLots(), Bid, 3);

if (OrderType() == OP_SELL)
OrderClose(OrderTicket(), OrderLots(), Ask, 3);
}
}
}
i++;
}
}

bool BullishMomentum(int bars)
{
double yesterdayClose = Close[1];
int i = 2;
bool isHighest = true;
while (i <= bars && isHighest == true)
{
if (yesterdayClose < Close)
isHighest = false;

i++;
}
return (isHighest);
}

bool BearishMomentum(int bars)
{
double yesterdayClose = Close[1];
int i = 2;
bool isLowest = true;
while (i <= bars && isLowest == true)
{
if (yesterdayClose > Close)
isLowest = false;

i++;
}
return (isLowest);
}

Hi,
Try replacing any line of division code in the EA with a piece of code to bypass the zero divide situation as in the example below.

if (dividefactor!=0)

result = MathRound((data1 - data2) / dividefactor);

else result = 0;

I am not a programmer. I dont know how to debug.

It works on currency pairs but not Gold & Silver.

Thanks..

piprange/pipvalue/getpositionsize, that is where I would start to look for the error (or replace the functions).

but it seems there are more bugs (no 2stage ordersend e.g.) - when copy&pasting it is not possible to compile the code, it looks like there are some brackets forgotten (or is it the editor which "eats" them?, etc., so attach the mql4 file please ...

Hi,

attached the ea.

Anyone can help ?

I solve this problem.
on 1 Jan 2014 at 00:00 GMT I will post the solution in separate topic.

Be there all.

My broker use 2 digits for Gold and 3 digits for Silver. Fyi.

Thanks...


Anyone ?

any code must be comprehensive, include all digit possibilities.

also, add JPY to Gold and Silv.

double tickSize = 0.0001;
????

this is not acceptable. make yr program more generic. try to use predifined variables(like Digits, Point, etc) instead of mere numbers

how do i do that ?

I am programming idiot. Those are not my code.

I got your email, Will Have a look but quite busy, have just started writing mql4 code to try and earn a living or at least enough capitol to trade a living!

it looks like it is just the digits problem if so should be easy sorted

Hi Andy,

Thanks alot. EA attached.


Mark

Well I tried it on roboforex brokerage and had no error but the gold is listed as xau/usd and the code as it was works out the pips by using the symbol if it contains /usd etc so if your broker lists gold as gold or goldspot then that might be the problem I have modified it anyway reducing about 50 lines of code. See if it is any better but try it before next week. Time is money but not a lot!

Hi Andy,

Yeah my broker listed symbol is Gold and Silver.

Not xau/usd... etc. Does your attachment solve this ?

It should do if that is what the problem is.

Hi Andy,

You mind sending the mq4 file to my email: [email protected]

Thanks.