I will code your EAs and Indicators for no charge
please can someone code this indcator to not give so many alerts,can we time it to give alert every 1hor or 4h? this is such a wide used and popular fvg indicator,may be someone already has it,please share,thanks please someone also explain what is HG color 1 and 2 as well? {file}
please can someone code this indcator to not give so many alerts,can we time it to give alert every 1hor or 4h? this is such a wide used and popular fvg indicator,may be someone already has it,please share,thanks please someone also explain what is HG color 1 and 2 as well? {file}
/*--------------------------------------------------------------------
Change-log: WRB-Hidden-Gap-BT_fix
MODIFIED:[13-05-2025]
By: MwlRCT
--------------------------------------------------------------------
- Added `AlertTimeframe` input parameter (extern int, default 60 minutes) to allow users to specify the desired interval for alert notifications.
- Implemented logic to restrict alerts to trigger only once per candle close on the user-selected `AlertTimeframe`, reducing alert frequency.
- Introduced a global variable `LastAlertTime` (datetime) to store the timestamp of the most recent alert.
- Modified the `CheckAlert()` function to:
- Validate the `AlertTimeframe` input, defaulting to 60 minutes if an invalid value (e.g., <= 0) is provided.
- Determine the opening time of the last closed candle (`currentCandleTime`) on the specified `AlertTimeframe` using `iTime(Symbol(), timeframe, 1)`.
- Trigger an alert only if a WRB rectangle is breached AND `LastAlertTime` is earlier than `currentCandleTime` AND `TimeCurrent()` is at or after `currentCandleTime`.
- Update `LastAlertTime` to `currentCandleTime` after an alert is successfully triggered to prevent multiple alerts for the same candle event.
--------------------------------------------------------------------*/ //+------------------------------------------------------------------+ //| WRB-Hidden-Gap.mq4 | //| Copyright ฉ 2010, Akif TOKUZ | //| [email protected] | //| Identifies Wide Range Bars and Hidden Gaps. | //| WRB and HG definitions are taken from the WRB Analysis Tutorial-1| //| by M.A.Perry from TheStrategyLab.com | //| | //| History: | //| 09.04.2014: Alerts and optimization. | //| 06.04.2010: Correction to make sure Hidden Gaps are not filled | //| with real gaps. | //| 03.04.2010: Initial release | //| | //+------------------------------------------------------------------+ #property copyright "Akif TOKUZ and EarnForex.com" #property link "http://www.earnforex.com" #property version "1.00" //#property strict #property description "Identifies Wide Range Bars and Hidden Gaps." #property description "WRB and HG definitions are taken from the WRB Analysis Tutorial-1" #property description "by M.A.Perry from TheStrategyLab.com." #property description "Alerts and optimization by Andriy Moraru." #property indicator_chart_window #property indicator_buffers 1 #property indicator_color1 clrAqua // WRB symbol #property indicator_width1 1 #define UNFILLED_PREFIX "HG_UNFILLED_" #define FILLED_PREFIX "HG_FILLED_" #define PREFIX "HG_" extern bool UseWholeBars = true; extern int WRB_LookBackBarCount = 3; extern int WRB_WingDingsSymbol = 115; extern color HGcolor1 = clrDodgerBlue; // Base color for Hidden Gap rectangles extern color HGcolor2 = clrDodgerBlue; // Alternate color for Hidden Gaps, used for visual distinction when HGs intersect extern ENUM_LINE_STYLE HGstyle = STYLE_SOLID; extern int StartCalculationFromBar = 500; extern bool HollowBoxes = false; extern bool DoAlerts = false; extern int AlertTimeframe = 60; // Alert Timeframe (minutes, e.g., 60 for H1, 240 for H4) extern ENUM_BASE_CORNER btn_corner = CORNER_LEFT_UPPER; extern string DisplayID = "WRB-Hidden_Gap-BT"; extern string btn_Font = "Arial"; extern int btn_FontSize = 10; extern color btn_on_color = clrLime; extern color btn_off_color = clrRed; extern color btn_text_color = clrWhite; extern color btn_background_color = clrDimGray; extern color btn_border_color = clrBlack; extern int button_x = 400; extern int button_y = 0; extern int btn_Width = 150; extern int btn_Height = 20; extern string button_note2 = "------------------------------"; bool show_data = true; bool recalc = true; //---- buffers double WRB[]; int totalBarCount = -1; datetime LastAlertTime = 0; // Track last alert time to limit frequency - MODIFIED [2023-11-10] - Objective 2 - Added for timeframe-based alerts //+------------------------------------------------------------------+ string IndicatorName, IndicatorObjPrefix ,buttonId; //+------------------------------------------------------------------+ string GenerateIndicatorName(const string target) { string name = target; int try = 2; while (WindowFind(name) != -1) { name = target + " #" + IntegerToString(try++); } return name; } //+------------------------------------------------------------------+ //+------------------------------------------------------------------+ int init() { //---- indicators IndicatorBuffers(1); //IndicatorShortName("WRB+HG"); SetIndexStyle(0, DRAW_ARROW); SetIndexArrow(0, WRB_WingDingsSymbol); SetIndexLabel(0, "WRB"); SetIndexBuffer(0, WRB); ArrayInitialize(WRB, EMPTY_VALUE); IndicatorName = GenerateIndicatorName(DisplayID ); IndicatorObjPrefix = "__" + IndicatorName + "__"; IndicatorShortName(WindowExpertName()); IndicatorDigits(1); double val; if (GlobalVariableGet(IndicatorName + "_visibility", val)) show_data = val != 0; ChartSetInteger(0, CHART_EVENT_MOUSE_MOVE, 1); buttonId = IndicatorObjPrefix+DisplayID; createButton(buttonId,DisplayID, btn_Width, btn_Height, btn_Font, btn_FontSize, btn_background_color, btn_border_color, btn_on_color); ObjectSetInteger(0,buttonId, OBJPROP_YDISTANCE, button_y); ObjectSetInteger(0,buttonId, OBJPROP_XDISTANCE, button_x); return(0); } //+------------------------------------------------------------------+ //| Delete all objects with given prefix | //+------------------------------------------------------------------+ void ObDeleteObjectsByPrefix(string Prefix) { int L = StringLen(Prefix); int i = 0; while(i < ObjectsTotal()) { string ObjName = ObjectName(i); if(StringSubstr(ObjName, 0, L) != Prefix) { i++; continue; } ObjectDelete(ObjName); } } //+------------------------------------------------------------------+ int deinit2() { ObDeleteObjectsByPrefix(PREFIX); SetIndexStyle(0, DRAW_NONE); return(0); } //+------------------------------------------------------------------+ int deinit() { deinit2(); ObjectsDeleteAll(ChartID(), IndicatorObjPrefix); return(0); } //+------------------------------------------------------------------+ void createButton(string buttonID,string buttonText,int width,int height,string font,int fontSize,color bgColor,color borderColor,color txtColor) { ObjectDelete (0,buttonID); ObjectCreate (0,buttonID,OBJ_BUTTON,0,0,0); ObjectSetInteger(0,buttonID,OBJPROP_COLOR,txtColor); ObjectSetInteger(0,buttonID,OBJPROP_BGCOLOR,bgColor); ObjectSetInteger(0,buttonID,OBJPROP_BORDER_COLOR,borderColor); ObjectSetInteger(0,buttonID,OBJPROP_BORDER_TYPE,BORDER_RAISED); ObjectSetInteger(0,buttonID,OBJPROP_XSIZE,width); ObjectSetInteger(0,buttonID,OBJPROP_YSIZE,height); ObjectSetString (0,buttonID,OBJPROP_FONT,font); ObjectSetString (0,buttonID,OBJPROP_TEXT,buttonText); ObjectSetInteger(0,buttonID,OBJPROP_FONTSIZE,fontSize); ObjectSetInteger(0,buttonID,OBJPROP_SELECTABLE,0); ObjectSetInteger(0,buttonID,OBJPROP_CORNER,btn_corner); ObjectSetInteger(0,buttonID,OBJPROP_HIDDEN,1); ObjectSetInteger(0,buttonID,OBJPROP_XDISTANCE,9999); ObjectSetInteger(0,buttonID,OBJPROP_YDISTANCE,9999); } //+------------------------------------------------------------------+ void handleButtonClicks() { if (ObjectGetInteger(0, buttonId, OBJPROP_STATE)) { ObjectSetInteger(0, buttonId, OBJPROP_STATE, false); show_data = !show_data; GlobalVariableSet(IndicatorName + "_visibility", show_data ? 1.0 : 0.0); recalc = true; start(); } } //+------------------------------------------------------------------+ void OnChartEvent(const int id,const long &lparam,const double &dparam,const string &sparam) { handleButtonClicks(); if (id==CHARTEVENT_OBJECT_CLICK && ObjectGet(sparam,OBJPROP_TYPE)==OBJ_BUTTON) if (show_data) { init(); start(); ObjectSetInteger(ChartID(),buttonId,OBJPROP_COLOR,btn_on_color); } else { ObjectSetInteger(ChartID(),buttonId,OBJPROP_COLOR,btn_off_color); deinit2(); } } //+------------------------------------------------------------------+ int start() { handleButtonClicks(); recalc = false; int NumBar = 500; if (DoAlerts) CheckAlert(); // A new bar started. //if (totalBarCount != Bars) // { //int begin = Bars - IndicatorCounted(); int begin = (NumBar>0) ? NumBar-1 : (Bars-2)/_Period; // Need at least WRB_LookBackBarCount bars from the end of the chart to work. if (begin > NumBar - WRB_LookBackBarCount) begin = NumBar - WRB_LookBackBarCount; // Maximum number of bars to calculate is StartCalculationFromBar. if (begin > StartCalculationFromBar) begin = StartCalculationFromBar; for (int i = begin; i > 0; i--) { checkWRB(i); checkHG(i); checkHGFilled(i); } totalBarCount = Bars; //} // Additional check to see if current bar made the Hidden Gap filled. checkHGFilled(0); WRB[0] = EMPTY_VALUE; if (show_data) { ObjectSetInteger(ChartID(),buttonId,OBJPROP_COLOR,btn_on_color); } else { ObjectSetInteger(ChartID(),buttonId,OBJPROP_COLOR,btn_off_color); deinit2(); } return(0); } //+------------------------------------------------------------------+ void CheckAlert() { int total = ObjectsTotal(); // Loop over all unfilled boxes. for (int j = 0; j < total; j++) { string ObjectText = ObjectName(j); // Object marked as alerted. if (StringSubstr(ObjectText, StringLen(ObjectText) - 1, 1) == "A") { // Try to find a dupe object (could be result of a bug) and delete it. string ObjectNameWithoutA = StringSubstr(ObjectText, 0, StringLen(ObjectText) - 1); if (ObjectFind(ObjectNameWithoutA) >= 0) ObjectDelete(ObjectNameWithoutA); continue; } int Length = StringLen(UNFILLED_PREFIX); if (StringSubstr(ObjectText, 0, Length) != UNFILLED_PREFIX) continue; double Price1 = ObjectGet(ObjectText, OBJPROP_PRICE1); double Price2 = ObjectGet(ObjectText, OBJPROP_PRICE2); double bHigh = MathMax(Price1, Price2); double bLow = MathMin(Price1, Price2); // Current price above lower border if ((Ask > bLow) && (Bid < bHigh)) { // Check if AlertTimeframe is valid, else default to 60 minutes int timeframe = (AlertTimeframe > 0) ? AlertTimeframe : 60; // Get the time of the last closed candle on the specified timeframe datetime currentCandleTime = iTime(Symbol(), timeframe, 1); if (LastAlertTime < currentCandleTime && TimeCurrent() >= currentCandleTime) { Alert(Symbol() + ": " + "WRB rectangle breached."); PlaySound("alert.wav"); LastAlertTime = currentCandleTime; // Update last alert time - MODIFIED [2023-11-10] - Objective 3 - Restrict alerts to candle close ObjectSetString(0, ObjectText, OBJPROP_NAME, ObjectText + "A"); return; } } } } //+------------------------------------------------------------------+ int intersect(double H1, double L1, double H2, double L2) { if ( (L1>H2) || (H1<L2) ) return (0); if ( (H1>=H2) && (L1>=L2) ) return (1); if ( (H1<=H2) && (L1<=L2) ) return (2); if ( (H1>=H2) && (L1<=L2) ) return (3); if ( (H1<=H2) && (L1>=L2) ) return (4); return(0); } //+------------------------------------------------------------------+ //| checkHGFilled: Check if the hidden gap is filled or not | //+------------------------------------------------------------------+ void checkHGFilled(int barNumber) { int j, i; string ObjectText; string Prefix = UNFILLED_PREFIX; double box_H, box_L; double HGFillPA_H, HGFillPA_L; datetime startTime; //color objectColor; int L = StringLen(Prefix); i = 0; while(i < ObjectsTotal()) // loop over all unfilled boxes { string ObjName = ObjectName(i); if(StringSubstr(ObjName, 0, L) != Prefix) { i++; continue; } box_H=ObjectGet(ObjName, OBJPROP_PRICE1); // get HG high and low values box_L=ObjectGet(ObjName, OBJPROP_PRICE2); //objectColor=ObjectGet(ObjName, OBJPROP_COLOR); startTime=(int)ObjectGet(ObjName, OBJPROP_TIME1); HGFillPA_H = High[barNumber]; HGFillPA_L = Low[barNumber]; j = 0; while ( (intersect(High[barNumber+j], Low[barNumber+j], box_H, box_L)!=0) && (barNumber+j<Bars) && (startTime<Time[barNumber+j])) { if (High[barNumber+j] > HGFillPA_H) HGFillPA_H = High[barNumber+j]; if (Low[barNumber+j] < HGFillPA_L) HGFillPA_L = Low[barNumber+j]; if ( (HGFillPA_H>box_H) && (HGFillPA_L<box_L) ) { ObjectDelete(ObjName); ObjectText = FILLED_PREFIX + TimeToStr(startTime,TIME_DATE|TIME_MINUTES); ObjectCreate(ObjectText, OBJ_RECTANGLE, 0, startTime, box_H, Time[barNumber], box_L); ObjectSet(ObjectText, OBJPROP_STYLE, HGstyle); //ObjectSet(ObjectText, OBJPROP_COLOR, objectColor); ObjectSet(ObjectText,OBJPROP_COLOR, ObjectGet(ObjName, OBJPROP_COLOR)); ObjectSet(ObjectText, OBJPROP_BACK, !HollowBoxes); break; } j++; } i++; } } //+------------------------------------------------------------------+ //| checkWRB: Check if the given bar is a WRB or not | //| The lookback period can be changed by user input | //+------------------------------------------------------------------+ bool checkWRB(int i) { int j; bool WRB_test; double body, bodyPrior; WRB_test = true; if (UseWholeBars) body = High[i] - Low[i]; else body = MathAbs(Open[i] - Close[i]); for (j = 1;j <= WRB_LookBackBarCount; j++) { if (UseWholeBars) bodyPrior = High[i + j] - Low[i + j]; else bodyPrior = MathAbs(Open[i+j]-Close[i+j]); if (bodyPrior>body) { WRB_test = false; break; } } if (WRB_test) { if (UseWholeBars) WRB[i] = (High[i] + Low[i]) / 2; else WRB[i] = (Open[i] + Close[i]) / 2; } else WRB[i] = EMPTY_VALUE; return(WRB_test); } //+------------------------------------------------------------------+ //| checkHG: Checks HG status of the previous bar. | //+------------------------------------------------------------------+ void checkHG(int i) { string ObjectText; double H,L,H2,L2,H1,L1,A,B; int j; color HGcolor=HGcolor1; // HG-TEST ( test the previous bar i+1) if (WRB[i+1]!=EMPTY_VALUE) // First rule to become a HG is to become a WRB { H2 = High[i+2]; L2 = Low[i+2]; H1 = High[i]; L1 = Low[i]; if (UseWholeBars) { H = High[i + 1]; L = Low[i + 1]; } else if (Open[i+1]>Close[i+1]) { H = Open[i+1]; L = Close[i+1]; } else { H = Close[i+1]; L = Open[i+1]; } // Older bar higher than the newer. if (L2 > H1) { A = MathMin(L2, H); B = MathMax(H1, L); } else if (L1 > H2) { A = MathMin(L1, H); B = MathMax(H2, L); } else return; if (A > B) { int Length = StringLen(UNFILLED_PREFIX); j = 0; while(j < ObjectsTotal()) // loop over all unfilled boxes { ObjectText = ObjectName(j); if(StringSubstr(ObjectText, 0, Length) != UNFILLED_PREFIX) { j++; continue; } // Switch colors if the new Hidden Gap is intersecting with previous Hidden Gap. if (intersect(ObjectGet(ObjectText, OBJPROP_PRICE1),ObjectGet(ObjectText, OBJPROP_PRICE2),A,B)!=0) { HGcolor = ObjectGet(ObjectText, OBJPROP_COLOR); if (HGcolor==HGcolor1) HGcolor=HGcolor2; else HGcolor=HGcolor1; break; } j++; } ObjectText = UNFILLED_PREFIX + TimeToStr(Time[i+1],TIME_DATE|TIME_MINUTES); ObjectCreate(ObjectText, OBJ_RECTANGLE, 0, Time[i+1], A, TimeCurrent() + 10 * 365 * 24 * 60 * 60, B); ObjectSet(ObjectText, OBJPROP_STYLE, HGstyle); ObjectSet(ObjectText, OBJPROP_COLOR, HGcolor); ObjectSet(ObjectText, OBJPROP_BACK, !HollowBoxes); } } //End of HG-Test } //+------------------------------------------------------------------+
{quote} To be blunt, both those codes are atrocious, there are so many things that are wrong or redundant, it's easier to write what should be done- - 1 buffer only, set as series once in oninit - set the handle with mtf tf in oninit, it will not be ready for access at once - in oncalc when prevcalc is 0, check barscalc for the handle, if <0 it's not ready, return 0, wait for the next tick or programmatically refresh via chartsetsymperiod - if handle is ready, then loop through the chart history and copy the handle buffer index corresponding to...
#property indicator_chart_window
#property indicator_buffers 1
#property indicator_plots 1
#property strict
#property indicator_type1 DRAW_LINE
#property indicator_color1 0xFFAA00
#property indicator_width1 2
#define CALC_BARS 90
double Buffer[];
int MA_handle;
int OnInit()
{
SetIndexBuffer(0, Buffer, INDICATOR_DATA);
PlotIndexSetDouble(0, PLOT_EMPTY_VALUE, EMPTY_VALUE);
PlotIndexSetInteger(0, PLOT_DRAW_BEGIN, CALC_BARS);
ArraySetAsSeries(Buffer, true);
MA_handle = iMA(Symbol(), PERIOD_M3, 14, 0, MODE_EMA, PRICE_CLOSE);
if(MA_handle == INVALID_HANDLE)
{
Print("Failed to create MA handle. Error: ", GetLastError());
return(INIT_FAILED);
}
return(INIT_SUCCEEDED);
}
int OnCalculate(const int rates_total,
const int prev_calculated,
const datetime &time[],
const double &open[],
const double &high[],
const double &low[],
const double &close[],
const long &tick_volume[],
const long &volume[],
const int &spread[])
{
if(rates_total < CALC_BARS)
return(0);
if(prev_calculated == 0)
{
int ready = BarsCalculated(MA_handle);
if(ready < CALC_BARS)
{
Print("MA_handle not ready. BarsCalculated = ", ready);
return(0);
}
}
double ma_values[];
if(CopyBuffer(MA_handle, 0, 0, CALC_BARS, ma_values) <= 0)
{
Print("CopyBuffer failed. Error: ", GetLastError());
return(0);
}
datetime t[];
if(CopyTime(Symbol(), PERIOD_CURRENT, 0, CALC_BARS, t) <= 0)
{
Print("CopyTime failed. Error: ", GetLastError());
return(0);
}
ArraySetAsSeries(t, true);
ArraySetAsSeries(ma_values, true);
for(int i = 0; i < CALC_BARS; i++)
{
int h1_index = iBarShift(Symbol(), PERIOD_M3, t[i], false);
if(h1_index >= 0 && h1_index < CALC_BARS)
Buffer[i] = ma_values[h1_index];
else
Buffer[i] = EMPTY_VALUE;
}
return(rates_total);
} {quote} Maybe because you don't have data updated on higher Tfs, and you first need to download that data???
My Question
Suppose I have a multi-timeframe indicator for MetaTrader 5
This indicator works well in the live market and by changing the timeframe the moving average is drawn well when we go to a lower timeframe
But when the market is closed, the indicator only works on the main timeframe for which the handle is set
And on lower timeframes the average is not displayed
What is the reason for this?
Is it because the calculation function does different calculations when the market is live than when the market is closed?
AI:
Yes, the issue you're describing can indeed be related to the way MetaTrader 5 handles indicator calculations in live and offline market conditions.
Here's what's likely happening:
1. Real-Time vs Offline Data in MetaTrader 5:
When the market is live, MetaTrader 5 continuously receives new data (tick data), and indicators can update in real-time. This is why the moving average (or other indicators) are plotted correctly on all timeframes, including lower timeframes.
When the market is closed, however, MetaTrader 5 no longer receives tick data, and the platform doesn't update the price data. In this state, any indicator that requires new price data (such as a moving average) will no longer be updated.
2. Multi-Timeframe Indicators and Data Availability:
For multi-timeframe indicators, the indicator is often calculated using data from a higher timeframe. When the market is open, the platform dynamically pulls the latest data and updates the indicator on all timeframes. However, when the market is closed, MetaTrader 5 may only have incomplete data or historical data for the lower timeframes and may not calculate or plot the moving average properly.
In particular:
- Live market: The indicator can calculate and plot on all timeframes as it receives live price data for all of them.
- Market closed: The indicator may fail to plot on lower timeframes because it cannot access live data to perform its calculations. It might be restricted to working only on the "main" timeframe (typically the one the handle is set to) because it lacks the necessary price data for lower timeframes.
3. Indicator Calculation with Historical Data:
If the indicator only works on the main timeframe when the market is closed, it could also indicate that your indicator is not designed to handle the lack of live data in the same way on lower timeframes. It may be relying on real-time updates that aren't available in the offline state, or it could be using historical data incorrectly.
Possible Solutions:
- Ensure Historical Data Availability: Ensure that there is enough historical data available for the lower timeframes. You might need to download or import the historical data for those timeframes.
- Use iTime and iClose Functions Appropriately: Ensure that your indicator uses the correct data functions (iTime, iClose, iOpen, etc.) that can access historical data even when the market is closed.
- Check Buffer Logic: Verify that the buffers or arrays your indicator uses are correctly populated with data, especially when the market is closed. If you rely on live data, the lack of new ticks in the offline state can disrupt the calculations.
In summary, the issue you're facing is most likely due to the fact that the indicator doesn't have access to the necessary price data for lower timeframes when the market is closed. The indicator may be functioning normally in live conditions but is limited by the absence of live data in the offline environment.
other AI:
MTF indicators depend on new ticks; closed market means no new ticks, so indicator does not update lower timeframe data
- .
- onCalculate runs once in closed market and does not calculate historical values for other timeframes unless chart is refreshed programmatically
- .
- Workarounds include forcing chart refresh with ChartSetSymbolPeriod and updating buffers on chart events rather than ticks
- .
ChartSetSymbolPeriod
{quote} Assume it is the weekend now, and I have tested several times. On weekends, I download the complete data and the market is closed, yet the same issue happens. Sometimes when I switch to a lower timeframe and add another indicator, the moving average is drawn, but when I change the timeframe again, the moving average no longer appears. gif animation
{quote} AI forgot about one very important hint: Send your complaint at: {image}
{quote} Did you read this article? https://www.mql5.com/en/articles/2837
{quote}...On weekends, I download the complete data and the market is closed, yet the same issue happens. Sometimes when I switch to a lower timeframe and add another indicator, the moving average is drawn, but when I change the timeframe again, the moving average no longer appears...
kindly guide how to fix this code for pr = PERIOD_D1 it is not giving desired result extern ENUM_TIMEFRAMES pr; //+------------------------------------------------------------------+ //| Custom indicator initialization function | //+------------------------------------------------------------------+ int OnInit() { //--- indicator buffers mapping ObjectDelete("H10"); ObjectDelete("L10"); ObjectCreate(0,"H10",OBJ_TREND,0,iTime(Symbol(),pr,2),iHigh(Symbol(),pr,2),iTime(Symbol(),pr,1),iHigh(Symbol(),pr,1)); ObjectCreate(0,"L10",OBJ_TREND,0,iTime(Symbol(),pr,2),iLow(Symbol(),pr,2),iTime(Symbol(),pr,1),iLow(Symbol(),pr,1));...
