{quote} I added alerts. {file}
This is awesome.
Thanking you for making this place a great community.
I will load on chart and test.
I will code your EAs and Indicators for no charge
- #53,804
- Aug 17, 2022 7:18pm Aug 17, 2022 7:18pm
{quote} I added alerts. {file}
Thanks greatly for lending a helping hand to people like me.
I noticed that @ some crosses, the arrow did not show and @ some, it showed even with the wick/candle toucing.
Anyway to correct this. See snapshot below....
- #53,810
- Aug 18, 2022 5:09am Aug 18, 2022 5:09am
yes no, your idea is still raw.. after some testing.. with different settings.. here is universal code for buttons
and ChartRedraw(0); can be generally deleted from code: it's raw/useless function..Hi Tankk, Regarding my 'CustomCandles - any tmf v3 BT', what you called "your code" was not really mine at all, since all I did was take what had been written (with inefficient button code added) and I made only the button code better. I would never have created "init2()" function because it was only called by "init()" and nowhere else. I saw no benefit to it, but I wasn't diving into this or other non-button-code details at all.
In your OnChartEvent(), you added: if (id!=CHARTEVENT_OBJECT_CLICK || sparam!=PrefBT) return; That's perfect to eliminate further processing of all other irrelevant event id's. It's obvious, but I don't know why I didn't think of it. I will incorporate that into my code.
yes, it's defense of fool. but i saw, that it doesn't work in some induks either, so i removed that line from latest version of Zigzag.
In your start() routine, it starts with: if (!buttON[0]) { InitZero(0); return(0); }
This is inefficient in that when the button is "off", it runs "InitZero(0)" for every single tick.
because, i saw that standard function ObjectsDeleteAll(0,PREF,-1,-1); didn't work in some induks.
as result, i abandoned its use in favor for ALL_OBJ_DELETE();..
and if (!buttON[0]) { InitZero(0); return(0); } so it remained at beginning of start().
and in last ZigZag, i removed this line, replacing it with if (objSTATE(PrefBT)=="OFF") return(0);
I helped another coder who had taken my example but tried to implement it into a VIX indicator that uses buffers, much like Zigzag does.
I also eliminated the unnecessary use of "init2()", and changed "start()", "init()", etc. to "OnCalculate()", "OnInit", etc.
It eliminates the use of "IndicatorCounted", since OnCalculate uses "prev_calculated" as the equivalent (AFAIK). However, when I was still using "start()", I used a variable "recalc" (set inside of OnChartEvent when button turned "on") to force a complete chart update.
like positive cycle/loop for(i=0; i<limit; i++) there are also a lot of problems with it.. in future: when expanding functionality of induk..
instead of if(recalc) function, i usually use:
int limit=fmin(Bars-CountedBars-1+TFK,Bars-3-MAX); //+MAX*10*TFK
if (History>MAX) limit=fmin(History+MAX,Bars-3-MAX); //ALL_OBJ_DELETE(); } //limit+=MAX; comment(limit);
if (History<=MAX && NewTime!=iTime(NULL,1,0)) { limit=Bars-1; NewTime=iTime(NULL,1,0); } //Time[0]
this is universal bars counter: it is suitable for all types of indicators, except some graphical induks.
but this ZigZag has different bars counter: for example:
if (counted_bars==0)
{ limit=Bars-3-ExtDepth;
downloadhistory=true; }
VIX indy attached. You, jeanlouis, or anyone else is welcome to critique and tell me how it could be better.
1, in little things: it was possible to make everything more clean and beautiful.
and use less lowest slash _ it's hard to read such code.2, a lot of extra/useless settings for one button.. nevertheless, button is only application for induk.
3, is block adjustWindowHeight() useless function?
4, button is on main chart btn_Subwindow=0, and not in corresponding subwindow.. not every trader knows, how to calculate windows on chart.
5, when you install induk on chart, it is turned off.
6, when initializing induk, it turns off again.
7, when mass initializing or compiling files, will on/off button be reset? because you only have if(reason != REASON_CHARTCHANGE) ObjectDelete(buttonId);
8, you also have if (show_data) duplicated in lines 199 and 246.. why? or you could write if (!show_data) return; ?
when i talk about universality of code, it means, that code should be broken down on blocks in such way, that it can be easily copy/past into other induks..
that is, we construct new induk according principle of Lego constructor.
of course, universal code should work stably in all types of indicators: averages, oscillators, graphical...
here is example of simple/stable VIX without button - https://www.forexfactory.com/thread/...8#post13804638
considering all above, i have question/suggestion for you:if you have time, write universal code for 2 buttons.
for example, 2 oscillators in same subwindow: Stochastic and RSI.. or CCI and MACD.. let's see....
study indicator settings and test it well...
- #53,814
- Edited Aug 19, 2022 1:50am Aug 18, 2022 9:40am | Edited Aug 19, 2022 1:50am
{quote} Hi bingo2015 thank you for your file but your file different from my trick . your file don't made to send picture if I want to send picture from your file I think I will have to create a new library. it have long time . I have vdo how to send alert and picture .this use library if you want to made from yourself. inbox me I'll tell you the last step how to do it. For other people this indicator I made for "bingo2015" I lock his ChatID . you won't be able to use it. {image} {image} {file}
I was able to use it. However, there is a problem that when touching the trendline it will send a notification Many times continuously. if you can fix that just notify once the trendline is touched or Note the currency pair name under telegram snapshot the indicator will work better. hi
I want to inbox you but I don't know where to inbox
Thank you again
- #53,820
- Aug 18, 2022 2:02pm Aug 18, 2022 2:02pm
{quote} MAs_MTF_toggle_v1.6 - unique id input to load multiple times {image} {file}
I appreciate your prompt response and the work you do for me and the community
. Thank you very much!!! It was just what I needed.
Blessings!!!
Is it possible - I hope and it's not too much to ask - you can add alerts to the indicator?
For example: when the MA1 cross the MA2, the indicator shows me an alert telling me
that this has happened, and so with the others MAs.
Thank you