EA to Set SL & TP of Open Trades Automatically

extern double TPpip=1400.0; //TP in Pips
extern double SLpip=60.0;   //SL in Pips
 
double cPoint=MarketInfo(Symbol(),MODE_POINT)*10;
 
//+------------------------------------------------------------------+
//| Expert tick function                                             |
//+------------------------------------------------------------------+
void OnTick() {
 
   for(int i=OrdersTotal()-1; i>=0; i--)
   if(OrderSelect(i,SELECT_BY_POS,MODE_TRADES))
   if(OrderStopLoss()==0 || (OrderTakeProfit()==0 && OrderStopLoss()==0)) {
      if(OrderType()==OP_BUY) {
         if(!OrderModify(OrderTicket(),OrderOpenPrice(),OrderOpenPrice()-SLpip*cPoint,OrderOpenPrice()+TPpip*cPoint,0,clrNONE))
            Print("OrderModified BUY Error:",Symbol(),":",GetLastError());
      }
 
      if(OrderType()==OP_SELL) {
         if(!OrderModify(OrderTicket(),OrderOpenPrice(),OrderOpenPrice()+SLpip*cPoint,OrderOpenPrice()-TPpip*cPoint,0,clrNONE))
            Print("OrderModified SELL Error:",Symbol(),":",GetLastError());
      }
}
}

Quote

Disliked

if(OrderSymbol()!=Symbol())continue;

Quoting kennyhubbard

Disliked

Your EA is modifying all trades off all the charts you running it on, so if you run it on XAU, it is going to try and modify your EU trades as well, with the consequent incorrect point info. After your OrderSelect add a line like this :- {quote} Now you telling the EA to only modify trades of the symbol that matches the chart.

Ignored

extern double TPpip=1400.0; //TP in Pips
extern double SLpip=60.0;   //SL in Pips
 
double cPoint=MarketInfo(Symbol(),MODE_POINT)*10;
 
//+------------------------------------------------------------------+
//| Expert tick function                                             |
//+------------------------------------------------------------------+
void OnTick() {
 
   for(int i=OrdersTotal()-1; i>=0; i--)
   if(OrderSelect(i,SELECT_BY_POS,MODE_TRADES))
   if(OrderStopLoss()==0 || (OrderTakeProfit()==0 && OrderStopLoss()==0))
   if(OrderSymbol()!=Symbol())continue; {
 
      if(OrderType()==OP_BUY) {
         if(!OrderModify(OrderTicket(),OrderOpenPrice(),OrderOpenPrice()-SLpip*cPoint,OrderOpenPrice()+TPpip*cPoint,0,clrNONE))
            Print("OrderModified BUY Error:",Symbol(),":",GetLastError());
      }
 
      if(OrderType()==OP_SELL) {
         if(!OrderModify(OrderTicket(),OrderOpenPrice(),OrderOpenPrice()+SLpip*cPoint,OrderOpenPrice()-TPpip*cPoint,0,clrNONE))
            Print("OrderModified SELL Error:",Symbol(),":",GetLastError());
      }
}
}

void OnTick()
  {
   double sl = SLpip * cPoint;
   double tp = SLpip * cPoint;
   for(int i=OrdersTotal()-1; i>=0; i--)
     {
      if(OrderSelect(i,SELECT_BY_POS,MODE_TRADES))
         if(OrderSymbol()!=Symbol())
            continue;
      if(OrderStopLoss()==0 || (OrderTakeProfit()==0 && OrderStopLoss()==0))
        {
         if(OrderType()==OP_BUY)
           {
            sl = OrderOpenPrice()-sl;
            tp = OrderOpenPrice() + tp;
            if(!OrderModify(OrderTicket(),OrderOpenPrice(),NormalizeDouble(OrderClosePrice()-SLpip*cPoint,Digits),NormalizeDouble(OrderClosePrice()+TPpip*cPoint,Digits),0,clrNONE))
               Print("OrderModified BUY Error:",Symbol(),":",GetLastError()," ",sl," ",tp);
           }
         if(OrderType()==OP_SELL)
           {
            if(!OrderModify(OrderTicket(),OrderOpenPrice(),NormalizeDouble(OrderClosePrice()+SLpip*cPoint,Digits),NormalizeDouble(OrderClosePrice()-TPpip*cPoint,Digits),0,clrNONE))
               Print("OrderModified SELL Error:",Symbol(),":",GetLastError());
           }
        }
     }
  }

Quote

Disliked

sl = OrderOpenPrice()-sl;
tp = OrderOpenPrice() + tp;

Quoting chimoong

Disliked

{quote} Hi Kenny, thank you for your reply. I added the following as follows, but it is not working, kindly advise, thanks. extern double TPpip=1400.0; //TP in Pips extern double SLpip=60.0; //SL in Pips double cPoint=MarketInfo(Symbol(),MODE_POINT)*10; //+------------------------------------------------------------------+ //| Expert tick function | //+------------------------------------------------------------------+ void OnTick() { for(int i=OrdersTotal()-1; i>=0; i--) if(OrderSelect(i,SELECT_BY_POS,MODE_TRADES)) if(OrderStopLoss()==0 || (OrderTakeProfit()==0...

Ignored

Quoting kennyhubbard

Disliked

Chimoong, i will have to consider the rounding problem tomorrow as it’s past my bedtime. Isuspect it has more to do with your multiplying the point by 10. Try removing the multiplyer and manually increase your stops x 10. I should also correct myself. You don’t have to use OrderClosePrice for calculating the stops. I just realised that I was getting an error with OrderOpenPrice because I was running the EA on a trade that was a day old and the price action had moved beyond the stops. If you only run on new trades you can use openprice but if you...

Ignored

Quoting kennyhubbard

Disliked

chimoong, I think you will find the rounding issue is because I used OrderClosePrice, so the TP & SL is off by the value of the spread. I reckon if you change to OpenPrice, the problem will go away. Try it and let me know.

Ignored

Quoting kennyhubbard

Disliked

Ok, here you go. I haven't tested it extensively but seems to work. It will only set tp & sl of the symbol of the chart it is running on. If you want to it set the stops of other symbols, you must run it on those chart as well, so you will be running it on multiple chart, ie the 4 charts you mentioned in your first post. {file}

Ignored

Quoting kennyhubbard

Disliked

Ok, try this {file}

Ignored