I will code your EAs and Indicators for no charge

I have both the same with me and yes,you are right the mt5 ver not working as expected or as mt4,it must looking Mladen the original author for possible corrections
mt5 ver working only at one chart it applied,not affecting other charts

i'm a new coder and sometimes i come across things that i just don't know why they won't work.

please please please would someone take a look at my code and get it to show the 1 bar fractals once this is done im sure i can make the rest of the indicator im trying to build. many thanks in advance



//+------------------------------------------------------------------+
//| Ruokh-FractalLevels.mq4 |
//| Ruokh |
//+------------------------------------------------------------------+
#property copyright "Ruokh"
#property version "1.00"
#property description "Ruokh-FractalLevels:"
#property description "This indicator draws a"
#property description "Fractal based channel with midpoint,"
#property description "colour changes if Lambert Price Dot"
#property description "is above or below midpoint."
#property strict
#property indicator_chart_window
#property indicator_buffers 2

double FractalHighOnChart[];
double FractalLowOnChart [];

extern color FractalColour = clrYellow;
int input FractalSize = 4;

//+------------------------------------------------------------------+
//| Custom indicator initialization function |
//+------------------------------------------------------------------+
int OnInit()
{
//--- indicator buffers mapping
IndicatorBuffers(2);
IndicatorDigits (Digits);


SetIndexBuffer (0, FractalHighOnChart);
SetIndexStyle (0, DRAW_ARROW, STYLE_SOLID, FractalSize, FractalColour);
SetIndexArrow (0, 161);
SetIndexEmptyValue(0, 0.0);
SetIndexLabel (0, "FractalHigh");
// IndicatorShortName("FractalHigh");

SetIndexBuffer (1, FractalLowOnChart);
SetIndexStyle (1, DRAW_ARROW, STYLE_SOLID, FractalSize, FractalColour);
SetIndexArrow (1, 161);
SetIndexEmptyValue(1, 0.0);
SetIndexLabel (1, "FractalLow");
// IndicatorShortName("FractalLow");

//---
return(INIT_SUCCEEDED);
}
//+------------------------------------------------------------------+
//| Custom indicator iteration function |
//+------------------------------------------------------------------+
int OnCalculate(const int rates_total,
const int prev_calculated,
const datetime &time[],
const double &open[],
const double &high[],
const double &low[],
const double &close[],
const long &tick_volume[],
const long &volume[],
const int &spread[])
{
//---
//int limit = (rates_total - prev_calculated);

if(prev_calculated < 0)return(-1);//history error


//************ lookback not needed?******************

int lookback = 5;//if you need to read the prev bar first, start 1 bar late
int limit = MathMax(Bars -1 - lookback - prev_calculated, 0);//first loading prev_calculated is 0, then prev_calculated is equal to bars, so mathmax(bars-2-0,0) then mathmax(bars-2-bars,0)
//int limit = (rates_total - prev_calculated);


if(prev_calculated > 0)
limit++;
//--- return value of prev_calculated for next call
return(rates_total);


for(int i = limit - 1; i >= 0; i--)
{
double previousHi = High[i+1];
double previousHi2 = High[i+2];
double previousHi3 = High[i+3];

double previousLo = Low [i+1];
double previousLo2 = Low [i+2];
double previousLo3 = Low [i+3];


//bool fractalHighOnChart = ((previousHi3 <= previousHi2) && (previousHi < previousHi2));
//bool fractalLowOnChart = ((previousLo3 >= previousLo2) && (previousLo > previousLo2));

bool fractalHighOnChart = ((High[i+3] <= High[i+2]) && (High[i+1] < High[i+2]));
// bool fractalLowOnChart = ((previousLo3 >= previousLo2) && (previousLo > previousLo2));

bool fractalLowOnChart = ((previousLo2 < previousLo) && (previousLo2 <= previousLo3));



if(fractalHighOnChart)
{
FractalHighOnChart[i+2] = ( previousHi2 + ((previousHi2 - previousLo2) / 12) );
}


if(fractalLowOnChart)
{
FractalLowOnChart[i+2] = ( previousLo2 - ((previousHi2 - previousLo2) / 12) );
}


}


}
//+------------------------------------------------------------------+

The sensation occasionally of not knowing why something isn't working will never go away.

Because you're looking at [i+3] all the time, the initial limit needs to start from the end, minus 3 bars. ie without the lookback you'll start at the end, and then ask for the high/low values of +1+2+3 bars after the end, so having lookback pushes forward the starting limit so the bars you want info from exist.

This needs to always stay at the end of the whole block, do not put any code above it, it's saying that the block is finished and outputs a return value

Did you mean to place the arrow buffers at the fractal high/low +/- 12th of the bar height, or +/- 1/2 the bar height?

ty for your reply!


{quote} Because you're looking at [i+3] all the time, the initial limit needs to start from the end, minus 3 bars. ie without the lookback you'll start at the end, and then ask for the high/low values of +1+2+3 bars after the end, so having lookback pushes forward the starting limit so the bars you want info from exist.

yes i was trying to make the calculation rely on bars that existed on the chart so i think its necessary. adjusting this seems not to make it work so i think the error is not there.


{quote} Did you mean to place the arrow buffers at the fractal high/low +/- 12th of the bar height, or +/- 1/2 the bar height?

yes i was trying to make an offset so the whole of the bar can be seen with the fractal above it at an offset relative to the size of the candle


{quote} This needs to always stay at the end of the whole block, do not put any code above it, it's saying that the block is finished and outputs a return value

THANKYOU!!! it was the rates total error! so glad its working now!

Thanks for the reply. I don't understand though - is it an easy fix ?

Why cant you use the old compiled (by old compiler) from your own post
https://www.forexfactory.com/thread/...5#post10923135

Because it doesn't work. Don't worry I'll sort it out elsewhere.

Someone help me port this from MT5 to MT4.

Hi everyone , i need your help, someone help me modify this indicator for me please
is it possible to make "open/hide button" to show trading history ? instead of need to delete indi everytime i don't want to see it
Thank you so much

Hello JeanLouie season greetings and thanks for your great contribution to this thread last year you will continue to expand in knowledge of coding and among others you will attain high levels. Please i have a new broker that use suffix with their forex pairs and im finding it difficult to use the attached with the pairs though theres space for both prefix/suffix in the input i have tried it but the angle beats me pls kindly help me to see what should be done about it.THE SUFFIX...(z) was used.Thanks

Hi.
Please write a fibo indicator (MT4) working as in the screen: fibo 100 always stays stationary at a certain level and fibo 0 level "goes" with the price (up or down as in the image), staying at the lowest current price level (if the price go down fibo level 0 goes further with price) + separate alerts on fibo levels: 38, 50, 61 etc.
Unless it already is - please link.
Thanks.

Have a try with this, not tested on the new mt4 and hope the simple fix does the trick. Thanks for giving the ok to post it here claudia1.
-perhaps only use the .ex4 and rename it slightly (so not over written with the old mq4) if you don't have the mqh's to recompile.
-please make sure to test it works as intended as I can not guarantee that something may have broken.


Kind Regards,
T

Could someone help me fix this indicator? is a really good non repainting cycle indi for gbp pairs but it gives error "cannot open file" I´d appreciate if someone can fix it..

Many thanks T - I'll give it a go next week.

For starters ex4 files can't be modified. Ditch the broker or use a diff ind and be aware that the suffix will be an issue in every ind u use that has inbuilt symbol names.

My Humble request all master coder is it possible to code one fib tool like attached image . i want fib tool show ratios what i want show or insert ratios to show. i know it is possible with mt4 default fib tool but i used that tool measure for harmonic pattern . if you have any questions let me know. thanks

fib indicator tool default ratios
0.0
50.0
100.0

Hello, can someone please help me with this request. I just want demand only and supply only buttons attached to these demand and supply indicators. Thanks

Dear Coder and Master

please kindly take a look @ this picture I need a dashboard to reflect it .

https://www.forexfactory.com/bluerain did something closer to this in the past using this indicator , i dont have the modified mql file for 2.1 version sir ...


DR = daily range ..... red if ADR low is hit and green if ADR high is hit



Thanks

hello dear hope your well and in good health from all the good karma you get from being so kind

on the topic of kindness

do you posses and atr on chart ma that can acomadate these parameters in the images or if any one else has one im at a stumbling block in looking on a little renko mission at the moment

thanks to all who are kind and polite


also could kind master coder please look at script to see if it works(apparently does not) and could be modified
preferred adding on defined brick size net stake 1 lot as example adding an 8th on each brick

even trailing not based on atr and on defined brick size function

taking profit but leaving a micro lot in

modding so you can have 5 or so with different parameters ( as im looking at 4 renkos one of which is an offset when you get pain correlation on a standard and an offset the market goes divvy and fast moving which is why im looking at scripts )

if any one has any scripts or script knowledge i would be happy for some help

whishing good health and even better health to all

Thanks so much Jean i trust your judgement