Disliked{quote} There is nothing to fix - you say on your screenshot "down trend lines (all red ) above 100 no up trend lines ( all green) below level 100, why?" the answer to why? is it's because you are using such small periods and the code fills in the color using 1 bar back. Inidicator using color 1 bar back {image} Indicator using color only on current bar {image}Ignored
I will code your EAs and Indicators for no charge
- #31,242
- Nov 6, 2019 9:01am Nov 6, 2019 9:01am
- Joined Aug 2010 | Status: Life is easy, life is delightful. | 3,152 Posts
And you will leave pain to take care of itself.
- #31,249
- Nov 6, 2019 11:30am Nov 6, 2019 11:30am
- Joined Aug 2010 | Status: Life is easy, life is delightful. | 3,152 Posts
And you will leave pain to take care of itself.
- #31,250
- Nov 6, 2019 11:33am Nov 6, 2019 11:33am
- | Membership Revoked | Joined Jun 2011 | 9,885 Posts
To free Gazans of Hamas, use whatever it takes.
- #31,251
- Nov 6, 2019 11:34am Nov 6, 2019 11:34am
- Joined Aug 2010 | Status: Life is easy, life is delightful. | 3,152 Posts
And you will leave pain to take care of itself.
- #31,254
- Nov 6, 2019 11:41am Nov 6, 2019 11:41am
- Joined Aug 2010 | Status: Life is easy, life is delightful. | 3,152 Posts
And you will leave pain to take care of itself.
- #31,256
- Nov 6, 2019 11:50am Nov 6, 2019 11:50am
- | Membership Revoked | Joined Jun 2011 | 9,885 Posts
{quote} you are wrong, in that particular case - i mean iLowest(...MODE_LOW...) - you already have the lowest low: it's inside iLowest (see my c# code): you don't need to index the Low array: is not right, is not wrong.... it's just useless.
As I recall, NinjaScript MIN() function can be used to iterate over a range of bars to return the VALUE. mql4 MAthMin() works with only 2 values. I am not aware of any built-in mql4 functions that can iterate over an arbitrary range of values in an array and directly return the lowest value.
To free Gazans of Hamas, use whatever it takes.
{quote} No, iLowest() does not return the VALUE of the lowest low; it returns the INDEX (shift) into the array where that lowest value was found. {image}
Inserted Code
private int Lowest(int count, int startindex, List<Candle> bars)
{
int lowposition = -1;
decimal min = decimal.MaxValue;
int i = 0, j = 0;
for (i = startindex; j < count; i++, j++)
{
//bars.GetRange(startindex,count).
var tmpmin = bars[i].Low;
if (tmpmin < min)
{
min = tmpmin;
lowposition = i;
}
}
return lowposition;
} the min variable contains the lowest low; the method returns his position that it will be uset to index Low....but is useless because the result of that is again the lowest low
i don't use Ninjatrader, i'm writing from zero a trading bot based on an incredible model: it will be a mass destruction weapon!
- #31,258
- Nov 6, 2019 12:00pm Nov 6, 2019 12:00pm
- | Membership Revoked | Joined Jun 2011 | 9,885 Posts
{quote} yes i know but if you see my code: private int Lowest(int count, int startindex, List<Candle> bars) { int lowposition = -1; decimal min = decimal.MaxValue; int i = 0, j = 0; for (i = startindex; j < count; i++, j++) { //bars.GetRange(startindex,count). var tmpmin = bars[i].Low; if (tmpmin < min) { min = tmpmin; lowposition = i; } } return lowposition; } che min variable contains the lowest low; the method returns his position that it will be uset to index Low....but is useless because the result of that is again the lowest low
To free Gazans of Hamas, use whatever it takes.
- #31,259
- Nov 6, 2019 12:10pm Nov 6, 2019 12:10pm
- | Membership Revoked | Joined Jun 2011 | 9,885 Posts
{quote} yes i know but if you see my code: private int Lowest(int count, int startindex, List<Candle> bars) { int lowposition = -1; decimal min = decimal.MaxValue; int i = 0, j = 0; for (i = startindex; j < count; i++, j++) { //bars.GetRange(startindex,count). var tmpmin = bars.Low; if (tmpmin < min) { min = tmpmin; lowposition = i; } } return lowposition; } the min variable contains the lowest low; the method returns his position that it will be uset to index Low....but is useless because the result of that is again the lowest low
So why were you asking about getting the VALUE, but then write a custom function that only returns the INDEX to it? You don't need a custom function to get that index. The built-in function iLowest() already does it!
To free Gazans of Hamas, use whatever it takes.