Indicator Request - Commodity Selection Index - (CSI)

Quoting .Hawk.

Disliked

hi,

kindly post indicator here & mention what else needs to be added.

i will see what i can do

regards
.Hawk.

Ignored

Quoting .Hawk.

Disliked

hi

can someone change horizontal shape of dotted lines to just plain horizontal lines with customizable thickness. i hate the current star dotted look of s & R (Barry) lines.

Kindly add ' lookback period ' of candles or minutes as in how many candles or minutes we want to look back for S & R to be drawn.


thanks & regards
.Hawk.

Ignored

double pointz =MarketInfo(a_symbol_8, MODE_POINT);
double adx=iADX(a_symbol_8,TimeFrame,ADX_Period,MODE_CLOSE,MODE_MAIN,0);
double adx2=iADX(a_symbol_8,TimeFrame,ADX_Period,MODE_CLOSE,MODE_MAIN,0+14);
double atr=iATR(a_symbol_8,TimeFrame,ATR_Period,0);
string adxr=(adx+adx2)/2;
double dadxr = (adx+adx2)/2;

double pipvalue = MarketInfo(a_symbol_8,MODE_TICKVALUE);
double V = atr/pointz;
double marginrequired =MarketInfo(a_symbol_8,MODE_MARGINREQUIRED);
double M=MathSqrt(marginrequired);
double spread = MarketInfo(a_symbol_8,MODE_SPREAD);
double C = (spread * pipvalue);
double Ka= ( M / V );
double Kb= ( 1 / 150 + C );
string CSI = (dadxr * atr * Ka * Kb * 100);

   ObjectSetText(a_name_0 + "CSI", "CSI:            "+StringSubstr(CSI,0,3)+" ",9, "Segoe UI", White);
   ObjectSet(a_name_0 + "CSI", OBJPROP_CORNER, g_corner_188);
   ObjectSet(a_name_0 + "CSI", OBJPROP_XDISTANCE, gi_192 + ai_16);
   ObjectSet(a_name_0 + "CSI", OBJPROP_YDISTANCE, gi_196 + ai_20 + 80);

Quoting Dredding82

Disliked

Ok i think i found my F up....lol

Inserted Code

   ObjectSetText(a_name_0 + "CSI", "CSI:            "+StringSubstr(CSI,0,3)+" ",9, "Segoe UI", White);
   ObjectSet(a_name_0 + "CSI", OBJPROP_CORNER, g_corner_188);
   ObjectSet(a_name_0 + "CSI", OBJPROP_XDISTANCE, gi_192 + ai_16);
   ObjectSet(a_name_0 + "CSI", OBJPROP_YDISTANCE, gi_196 + ai_20 + 80);

had StringSubstr(CSI,6,4)..........Guess this is what i get for being a copy and paste coding mofo! lol

Ignored

Quoting zznbrm

Disliked

double CSI = (dadxr * atr * Ka * Kb * 100);

then use DoubleToStr( CSI, 0 );

Also, Kb is wrong, should be:

double kb = ( 1.0 / (150.0 + C) );

Ignored

Quoting Dredding82

Disliked

There is no need to add the indicator ...you can not do anything if you needed help to change this small bit of code.~~~~

Ignored

Quoting .Hawk.

Disliked

[color=Blue]thanks for the sarcasm dear, you failed to understand, when i said i will see what i can do, i actually meant, " i will see how i can get you help on this from someone who has helped me for a little cost, though i wasn't willing to pay him for the simple horizontal line thing as i believed it didn't need much of modification but i was willing to pay for your indy & post it here for your & everyone else' s benefit, obviously have dropped the idea now.

I HAVE NO INCLINATION TOWARDS ADDING ANY INDICATORS TO MY CHART, THOUGH I CONSIDERED...

Ignored

//+------------------------------------------------------------------+
//| Currency Selection Index                                         |
//+------------------------------------------------------------------+
double CSI(int x,int TimeFrame,int ADX_Period,int ATR_Period,double Pips2dbl,double Pips2points)
  {
   double CSIval;
   double adx=iADX(CurPairs[x],TimeFrame,ADX_Period,PRICE_CLOSE,MODE_MAIN,0);
   double adx2=iADX(CurPairs[x],TimeFrame,ADX_Period,PRICE_CLOSE,MODE_MAIN,0+ADX_Period);
   double adxr=0.5*(adx+adx2);
   double atr=iATR(CurPairs[x],TimeFrame,ATR_Period,0);
   //ATR in pips
   double atrval=atr/Pips2dbl;
   //Lot value and pip value in the deposit currency
   double LotValue=iClose(CurPairs[x],TimeFrame,0)*DeltaValuePerLot(CurPairs[x]);
   double pipvalue=LotValue*Pips2dbl;
   //V is the value of 1 pip move, i.e., the value of the basic increment of the ATR
   double V=pipvalue;
   double marginrequired=MarketInfo(CurPairs[x],MODE_MARGINREQUIRED);
   double M=MathSqrt(marginrequired);
   //Commission Cost in the Deposit Currency, eg: 7USD per 100K USD Round Trip";
   double CommissionCost=7;
   //Deposit Currency Commission Costs as pips
   //double CommissionPips=CommissionCost*0.1;
   //Spread in pips
   double spread=MarketInfo(CurPairs[x],MODE_SPREAD)/Pips2points;
   //Total Cost (C) of Trade = Spread + CommissionCost in the deposit currency
   //In this case we are converting the spread to commission costs. Nevertheless, here is a related discussion
   //on converting commissions to spread: http://www.forexfactory.com/showthread.php?p=8458967
   double C = (spread*pipvalue) + CommissionCost;
   double Ka= V/M;
   double Kb=1/(150+C);
   CSIval=adxr*atrval*Ka*Kb*100;
   return(CSIval);
  }
//+------------------------------------------------------------------+
//| DeltaValuePerLot                                                 |
//+------------------------------------------------------------------+
double DeltaValuePerLot(string pair="")
  {
   if(pair=="") pair=Symbol();
   return(MarketInfo(pair,MODE_TICKVALUE)/MarketInfo(pair,MODE_TICKSIZE)); // Not Point.
  }
//+------------------------------------------------------------------+
//| pips2dblFactor                                                   |
//+------------------------------------------------------------------+
void pips2dblFactor(string symbol)
  {
   int MDigits=StrToInteger(DoubleToStr(MarketInfo(symbol,MODE_DIGITS),0));
   if(MDigits%2==1)
     {
      // DE30=1/JPY=3/EURUSD=5 forum.mql4.com/43064#515262
      // Adjust for five (5) digit brokers
      pips2dbl=MarketInfo(symbol,MODE_POINT)*10;
      pips2points=10;
      Digitspips=1;
     }
   else
     {
      pips2dbl=MarketInfo(symbol,MODE_POINT);
      pips2points=1;
      Digitspips=0;
     }
  }
//+------------------------------------------------------------------+